This repository was archived by the owner on Feb 17, 2021. It is now read-only.
fix formatted_number for values below 1000#10
Open
bluemont wants to merge 1 commit intosandro:masterfrom
xpe:fix-formatted-number
Open
fix formatted_number for values below 1000#10bluemont wants to merge 1 commit intosandro:masterfrom xpe:fix-formatted-number
bluemont wants to merge 1 commit intosandro:masterfrom
xpe:fix-formatted-number
Conversation
Owner
|
Hi, thanks for the pull request. I closed the complementary website (rubybenchmark.com) down a while back, and have since, stopped work on this gem. |
Author
|
Ok. What do you like to use, if anything, instead? |
Owner
|
Hmm, I haven't used anything lately. If you'd like, I can make you a contributor, and you can work to get the project back on its feet. |
Author
|
Thanks, but I can't commit to any ongoing time involvement right now beyond a few pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote up this issue:
#9
Full disclosure: I've only tested this by hand. I could not get
rake specto work on my machine. I'm not sure what's up -- can you take a look?